evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

qcom-charger: Fix crash due to null ptr access of pl psy

Browse source 
pl psy access is guarded by pl_disable_votable, disabled in PMI
probe. Accessing parallel psy before it is available will cause
crash.

Fix this by allowing access to parallel psy only after all the
initial votes have been cast on pl_disable_votable in probe.

CRs-Fixed: 1101600
Change-Id: Idd289229f45c31cf8fd234339b6738bd241283bd
Signed-off-by: Harry Yang <harryy@codeaurora.org>
This commit is contained in:
Harry Yang 2016-12-14 16:02:47 -08:00
parent d9a8a3b2e1
commit a154041d04
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/power/qcom-charger/qpnp-smb2.c
View file

@ -1884,6 +1884,12 @@ static int smb2_probe(struct platform_device *pdev)
goto cleanup;
}
rc = smb2_init_hw(chip);
if (rc < 0) {
pr_err("Couldn't initialize hardware rc=%d\n", rc);
goto cleanup;
}
rc = smb2_init_dc_psy(chip);
if (rc < 0) {
pr_err("Couldn't initialize dc psy rc=%d\n", rc);
@ -1916,12 +1922,6 @@ static int smb2_probe(struct platform_device *pdev)
goto cleanup;
}
rc = smb2_init_hw(chip);
if (rc < 0) {
pr_err("Couldn't initialize hardware rc=%d\n", rc);
goto cleanup;
}
rc = smb2_determine_initial_status(chip);
if (rc < 0) {
pr_err("Couldn't determine initial status rc=%d\n",