evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

leds-lp8788: fix a parent device in _probe()

Browse source 
The lp8788-keyled is a platform driver of lp8788-mfd. The platform
device is allocated when mfd_add_devices() is called in lp8788-mfd.
On the other hand, 'lp->dev' is the i2c client device.

Therefore, this 'platform_device' is a proper parent device in case
of resource managed mem alloc, registering led device and device
kernel messages.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
This commit is contained in:
Kim, Milo 2013-01-02 22:28:12 -08:00 • committed by Bryan Wu
parent 08541cbcc7
commit a1932edf8b
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/leds/leds-lp8788.c
View file

@ -130,9 +130,10 @@ static int lp8788_led_probe(struct platform_device *pdev)
struct lp8788 *lp = dev_get_drvdata(pdev->dev.parent); struct lp8788 *lp = dev_get_drvdata(pdev->dev.parent);
struct lp8788_led_platform_data *led_pdata; struct lp8788_led_platform_data *led_pdata;
struct lp8788_led *led; struct lp8788_led *led;
struct device *dev = &pdev->dev;
int ret; int ret;
led = devm_kzalloc(lp->dev, sizeof(struct lp8788_led), GFP_KERNEL); led = devm_kzalloc(dev, sizeof(struct lp8788_led), GFP_KERNEL);
if (!led) if (!led)
return -ENOMEM; return -ENOMEM;
@ -154,13 +155,13 @@ static int lp8788_led_probe(struct platform_device *pdev)
ret = lp8788_led_init_device(led, led_pdata); ret = lp8788_led_init_device(led, led_pdata);
if (ret) { if (ret) {
dev_err(lp->dev, "led init device err: %d\n", ret); dev_err(dev, "led init device err: %d\n", ret);
return ret; return ret;
} }
ret = led_classdev_register(lp->dev, &led->led_dev); ret = led_classdev_register(dev, &led->led_dev);
if (ret) { if (ret) {
dev_err(lp->dev, "led register err: %d\n", ret); dev_err(dev, "led register err: %d\n", ret);
return ret; return ret;
} }