evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

jffs2: leaking jffs2_summary in function jffs2_scan_medium

Browse source 
In case of an error returned by file_dirty() 's' is not freed as the cleanup
path is skipped.

Reported by Coverity.

Signed-off-by: Christian Engelmayer <christian.engelmayer@frequentis.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
This commit is contained in:
Christian Engelmayer 2009-06-13 23:06:29 +02:00 • committed by David Woodhouse
parent 272023df26
commit a2ab0ce09e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
fs/jffs2/scan.c
View file

@ -196,7 +196,7 @@ int jffs2_scan_medium(struct jffs2_sb_info *c)
if (c->nextblock) { if (c->nextblock) {
ret = file_dirty(c, c->nextblock); ret = file_dirty(c, c->nextblock);
if (ret) if (ret)
return ret; goto out;
/* deleting summary information of the old nextblock */ /* deleting summary information of the old nextblock */
jffs2_sum_reset_collected(c->summary); jffs2_sum_reset_collected(c->summary);
} }
@ -207,7 +207,7 @@ int jffs2_scan_medium(struct jffs2_sb_info *c)
} else { } else {
ret = file_dirty(c, jeb); ret = file_dirty(c, jeb);
if (ret) if (ret)
return ret; goto out;
} }
break; break;