evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

msm: mdss: Remove code duplication in sspp config

Browse source 
When caching the SSPP(source surface post processing) pipes parameters
pipe type should be checked for all PP features. SSPP config
function was checking the pipe type for multiple features which results
in code duplication. This change removes the code duplication by moving
the checks to top of the function.

Change-Id: I5f817ba881ab3763132360a2870830e0c40c887b
Signed-off-by: Gopikrishnaiah Anandan <agopik@codeaurora.org>
This commit is contained in:
Gopikrishnaiah Anandan 2015-01-06 15:15:45 -08:00 • committed by David Keitel
parent fc10390561
commit a3beddf7a2
1 changed files with 8 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
drivers/video/fbdev/msm/mdss_mdp_pp.c
View file

@ -6082,19 +6082,17 @@ int mdss_mdp_pp_sspp_config(struct mdss_mdp_pipe *pipe)
pr_err("invalid params %p\n", pipe); pr_err("invalid params %p\n", pipe);
return -EINVAL; return -EINVAL;
} }
cache_res.mdss_pp_res = NULL;
cache_res.pipe_res = pipe;
ret = sspp_cache_location(pipe->type, &cache_res.block);
if (ret) {
pr_err("invalid cache res block for igc ret %d\n",
ret);
goto exit_fail;
}
len = pipe->pp_cfg.igc_cfg.len; len = pipe->pp_cfg.igc_cfg.len;
if ((pipe->pp_cfg.config_ops & MDP_OVERLAY_PP_IGC_CFG)) { if ((pipe->pp_cfg.config_ops & MDP_OVERLAY_PP_IGC_CFG)) {
if (pp_ops[IGC].pp_set_config) { if (pp_ops[IGC].pp_set_config) {
ret = sspp_cache_location(pipe->type,
&cache_res.block);
if (ret) {
pr_err("invalid cache res block for igc ret %d\n",
ret);
goto exit_fail;
}
cache_res.mdss_pp_res = NULL;
cache_res.pipe_res = pipe;
ret = pp_igc_lut_cache_params(&pipe->pp_cfg.igc_cfg, ret = pp_igc_lut_cache_params(&pipe->pp_cfg.igc_cfg,
&cache_res, false); &cache_res, false);
if (ret) { if (ret) {
@ -6153,9 +6151,6 @@ int mdss_mdp_pp_sspp_config(struct mdss_mdp_pipe *pipe)
} }
if ((pipe->pp_cfg.config_ops & MDP_OVERLAY_PP_PA_V2_CFG) && if ((pipe->pp_cfg.config_ops & MDP_OVERLAY_PP_PA_V2_CFG) &&
(pp_ops[PA].pp_set_config)) { (pp_ops[PA].pp_set_config)) {
cache_res.block = SSPP_VIG;
cache_res.mdss_pp_res = NULL;
cache_res.pipe_res = pipe;
ret = pp_pa_cache_params(&pipe->pp_cfg.pa_v2_cfg_data, ret = pp_pa_cache_params(&pipe->pp_cfg.pa_v2_cfg_data,
&cache_res); &cache_res);
if (ret) { if (ret) {
@ -6166,15 +6161,6 @@ int mdss_mdp_pp_sspp_config(struct mdss_mdp_pipe *pipe)
} }
if (pipe->pp_cfg.config_ops & MDP_OVERLAY_PP_PCC_CFG if (pipe->pp_cfg.config_ops & MDP_OVERLAY_PP_PCC_CFG
&& pp_ops[PCC].pp_set_config) { && pp_ops[PCC].pp_set_config) {
ret = sspp_cache_location(pipe->type,
&cache_res.block);
if (ret) {
pr_err("invalid cache res block for pcc ret %d\n",
ret);
goto exit_fail;
}
cache_res.mdss_pp_res = NULL;
cache_res.pipe_res = pipe;
ret = pp_pcc_cache_params(&pipe->pp_cfg.pcc_cfg_data, ret = pp_pcc_cache_params(&pipe->pp_cfg.pcc_cfg_data,
&cache_res); &cache_res);
if (ret) { if (ret) {