evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

USB: serial: digi_acceleport: fix OOB-event processing

Browse source 
commit 2e46565cf622dd0534a9d8bffe152a577b48d7aa upstream.

A recent change claimed to fix an off-by-one error in the OOB-port
completion handler, but instead introduced such an error. This could
specifically led to modem-status changes going unnoticed, effectively
breaking TIOCMGET.

Note that the offending commit fixes a loop-condition underflow and is
marked for stable, but should not be backported without this fix.

Reported-by: Ben Hutchings <ben@decadent.org.uk>
Fixes: 2d380889215f ("USB: serial: digi_acceleport: fix OOB data sanity
check")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2017-02-24 19:11:28 +01:00 • committed by Greg Kroah-Hartman
parent 4d95645f3d
commit a8cb5c02a2
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/usb/serial/digi_acceleport.c
View file

@ -1492,7 +1492,7 @@ static int digi_read_oob_callback(struct urb *urb)
return -1; return -1;
/* handle each oob command */ /* handle each oob command */
for (i = 0; i < urb->actual_length - 4; i += 4) { for (i = 0; i < urb->actual_length - 3; i += 4) {
opcode = buf[i]; opcode = buf[i];
line = buf[i + 1]; line = buf[i + 1];
status = buf[i + 2]; status = buf[i + 2];