evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

msm: mdss: Add more checks for mdss_mdp_pp_resume

Browse source 
Add more secure checks inside mdss_mdp_pp_resume function to avoid null
pointer dereference.

Change-Id: I79c3248317557e9455c18c6a47cd692703b02198
Signed-off-by: Ping Li <pingli@codeaurora.org>
[imaund@codeaurora.org: Resolved trivial context conflicts.]
Signed-off-by: Ian Maund <imaund@codeaurora.org>
This commit is contained in:
Ping Li 2014-08-20 16:58:17 -07:00 • committed by David Keitel
parent f44a833d60
commit a8f6640e62
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/video/fbdev/msm/mdss_mdp_pp.c
View file

@ -1914,12 +1914,17 @@ int mdss_mdp_pp_resume(struct mdss_mdp_ctl *ctl, u32 dspp_num)
u32 flags = 0, disp_num, bl, ret = 0;
struct pp_sts_type pp_sts;
struct mdss_ad_info *ad;
struct mdss_data_type *mdata = ctl->mdata;
struct mdss_data_type *mdata;
struct msm_fb_data_type *bl_mfd;
if (!mdata)
if (!ctl || !ctl->mdata || !ctl->mfd) {
pr_err("invalid input: ctl = 0x%p, mdata = 0x%p, mfd = 0x%p\n",
ctl, (!ctl) ? NULL : ctl->mdata,
(!ctl) ? NULL : ctl->mfd);
return -EPERM;
}
mdata = ctl->mdata;
if (dspp_num >= mdata->ndspp) {
pr_err("invalid dspp_num %d\n", dspp_num);
return -EINVAL;