evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: oplc_dcon: Fix compilation warning.

Browse source 
Fix compilation warning:
drivers/staging/olpc_dcon/olpc_dcon.c: In function ‘dcon_probe’:
drivers/staging/olpc_dcon/olpc_dcon.c:704:21: warning: ignoring
return value of ‘device_create_file’, declared with attribute warn_unused_result

and add cleaning of created files when creation of one failed.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Marek Belisko 2011-02-03 14:22:08 +01:00 • committed by Greg Kroah-Hartman
parent 3ad4e21960
commit a90dcd4f7d
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/staging/olpc_dcon/olpc_dcon.c
View file

@ -674,7 +674,7 @@ static int dcon_detect(struct i2c_client *client, struct i2c_board_info *info)
static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id) static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
{ {
int rc, i; int rc, i, j;
if (num_registered_fb >= 1) if (num_registered_fb >= 1)
fbinfo = registered_fb[0]; fbinfo = registered_fb[0];
@ -700,8 +700,14 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
goto edev; goto edev;
} }
for(i = 0; i < ARRAY_SIZE(dcon_device_files); i++) for(i = 0; i < ARRAY_SIZE(dcon_device_files); i++) {
device_create_file(&dcon_device->dev, &dcon_device_files[i]); rc = device_create_file(&dcon_device->dev,
&dcon_device_files[i]);
if (rc) {
dev_err(&dcon_device->dev, "Cannot create sysfs file\n");
goto ecreate;
}
}
/* Add the backlight device for the DCON */ /* Add the backlight device for the DCON */
@ -728,6 +734,9 @@ static int dcon_probe(struct i2c_client *client, const struct i2c_device_id *id)
return 0; return 0;
ecreate:
for (j = 0; j < i; j++)
device_remove_file(&dcon_device->dev, &dcon_device_files[j]);
edev: edev:
platform_device_unregister(dcon_device); platform_device_unregister(dcon_device);
dcon_device = NULL; dcon_device = NULL;