evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

USB: legousbtower: fix use-after-free on release

Browse source 
commit 726b55d0e22ca72c69c947af87785c830289ddbc upstream.

The driver was accessing its struct usb_device in its release()
callback without holding a reference. This would lead to a
use-after-free whenever the device was disconnected while the character
device was still open.

Fixes: fef526cae7 ("USB: legousbtower: remove custom debug macro")
Cc: stable <stable@vger.kernel.org>     # 3.12
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191009153848.8664-5-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2019-10-09 17:38:47 +02:00 • committed by Greg Kroah-Hartman
parent 72ff2f6214
commit a9640a94bb
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/usb/misc/legousbtower.c
View file

@ -302,6 +302,7 @@ static inline void tower_delete (struct lego_usb_tower *dev)
kfree (dev->read_buffer); kfree (dev->read_buffer);
kfree (dev->interrupt_in_buffer); kfree (dev->interrupt_in_buffer);
kfree (dev->interrupt_out_buffer); kfree (dev->interrupt_out_buffer);
usb_put_dev(dev->udev);
kfree (dev); kfree (dev);
} }
@ -820,7 +821,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device
mutex_init(&dev->lock); mutex_init(&dev->lock);
dev->udev = udev; dev->udev = usb_get_dev(udev);
dev->open_count = 0; dev->open_count = 0;
dev->disconnected = 0; dev->disconnected = 0;