evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[media] fc0011: Add some sanity checks and cleanups

Browse source 
Add some sanity checks to the calculations and make the REG_16 register write consistent
with the other ones.

Signed-off-by: Michael Buesch <m@bues.ch>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Michael Büsch 2013-02-07 12:19:30 -03:00 • committed by Mauro Carvalho Chehab
parent 03a497d4b4
commit aadb464010
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/media/tuners/fc0011.c
View file

@ -220,6 +220,7 @@ static int fc0011_set_params(struct dvb_frontend *fe)
/* Calc XIN. The PLL reference frequency is 18 MHz. */ /* Calc XIN. The PLL reference frequency is 18 MHz. */
xdiv = fvco / 18000; xdiv = fvco / 18000;
WARN_ON(xdiv > 0xFF);
frac = fvco - xdiv * 18000; frac = fvco - xdiv * 18000;
frac = (frac << 15) / 18000; frac = (frac << 15) / 18000;
if (frac >= 16384) if (frac >= 16384)
@ -346,6 +347,8 @@ static int fc0011_set_params(struct dvb_frontend *fe)
vco_cal &= FC11_VCOCAL_VALUEMASK; vco_cal &= FC11_VCOCAL_VALUEMASK;
switch (vco_sel) { switch (vco_sel) {
default:
WARN_ON(1);
case 0: case 0:
if (vco_cal < 8) { if (vco_cal < 8) {
regs[FC11_REG_VCOSEL] &= ~(FC11_VCOSEL_1 | FC11_VCOSEL_2); regs[FC11_REG_VCOSEL] &= ~(FC11_VCOSEL_1 | FC11_VCOSEL_2);
@ -427,7 +430,8 @@ static int fc0011_set_params(struct dvb_frontend *fe)
err = fc0011_writereg(priv, FC11_REG_RCCAL, regs[FC11_REG_RCCAL]); err = fc0011_writereg(priv, FC11_REG_RCCAL, regs[FC11_REG_RCCAL]);
if (err) if (err)
return err; return err;
err = fc0011_writereg(priv, FC11_REG_16, 0xB); regs[FC11_REG_16] = 0xB;
err = fc0011_writereg(priv, FC11_REG_16, regs[FC11_REG_16]);
if (err) if (err)
return err; return err;