From 8ddec64b62b199e45a90e03e194e55e4b54c1c5c Mon Sep 17 00:00:00 2001 From: Yunyun Cao Date: Tue, 19 Jun 2018 14:08:31 +0800 Subject: [PATCH] msm: sde: Add mutex unlock for debug buffer access in rotator mutex lock should be unlocked before returning if the offset is not right. Change-Id: I11945696d2c4078c28266312915837a812fedcc8 Signed-off-by: Yunyun Cao --- drivers/media/platform/msm/sde/rotator/sde_rotator_debug.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/msm/sde/rotator/sde_rotator_debug.c b/drivers/media/platform/msm/sde/rotator/sde_rotator_debug.c index a2381557070d..6640e414a798 100644 --- a/drivers/media/platform/msm/sde/rotator/sde_rotator_debug.c +++ b/drivers/media/platform/msm/sde/rotator/sde_rotator_debug.c @@ -1150,8 +1150,10 @@ static ssize_t sde_rotator_debug_base_reg_read(struct file *file, goto debug_read_error; } - if (dbg->off % sizeof(u32)) - return -EFAULT; + if (dbg->off % sizeof(u32)) { + rc = -EFAULT; + goto debug_read_error; + } ptr = dbg->base + dbg->off; tot = 0;