evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

USB: f_audio_source: Remove pm_qos request under non atomic context

Browse source 
Currently driver is removing pm_qos request after acquiring spinlock in
pcm_close() callback. This could cause warning as pm_qos_remove_request()
can sleep. Hence move removing pm_qos request before acquiring spin lock.

Change-Id: I8e898934c4e83b80c994b2a293abbd920589ac62
Signed-off-by: Vijayavardhan Vennapusa <vvreddy@codeaurora.org>
This commit is contained in:
Vijayavardhan Vennapusa 2017-06-23 14:45:49 +05:30
parent 85baaeb2e2
commit b12f86c5b2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/usb/gadget/function/f_audio_source.c
View file

@ -776,11 +776,11 @@ static int audio_pcm_close(struct snd_pcm_substream *substream)
struct audio_dev *audio = substream->private_data;
unsigned long flags;
spin_lock_irqsave(&audio->lock, flags);
/* Remove the QoS request */
pm_qos_remove_request(&audio->pm_qos);
spin_lock_irqsave(&audio->lock, flags);
audio->substream = NULL;
spin_unlock_irqrestore(&audio->lock, flags);