ASoC: Convert to devm_ioremap_resource()
Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Cc: Liam Girdwood <lrg@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
4d6dc3a735
commit
b25b5aa066
8 changed files with 25 additions and 29 deletions
|
@ -11,6 +11,7 @@
|
||||||
*/
|
*/
|
||||||
|
|
||||||
#include <linux/delay.h>
|
#include <linux/delay.h>
|
||||||
|
#include <linux/err.h>
|
||||||
#include <linux/io.h>
|
#include <linux/io.h>
|
||||||
#include <linux/init.h>
|
#include <linux/init.h>
|
||||||
#include <linux/module.h>
|
#include <linux/module.h>
|
||||||
|
@ -367,9 +368,9 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
|
||||||
if (!res)
|
if (!res)
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
|
|
||||||
info->regs = devm_request_and_ioremap(&pdev->dev, res);
|
info->regs = devm_ioremap_resource(&pdev->dev, res);
|
||||||
if (!info->regs)
|
if (IS_ERR(info->regs))
|
||||||
return -ENXIO;
|
return PTR_ERR(info->regs);
|
||||||
|
|
||||||
irq = platform_get_irq(pdev, 0);
|
irq = platform_get_irq(pdev, 0);
|
||||||
if (!irq)
|
if (!irq)
|
||||||
|
|
|
@ -380,9 +380,9 @@ static int ep93xx_i2s_probe(struct platform_device *pdev)
|
||||||
if (!res)
|
if (!res)
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
|
|
||||||
info->regs = devm_request_and_ioremap(&pdev->dev, res);
|
info->regs = devm_ioremap_resource(&pdev->dev, res);
|
||||||
if (!info->regs)
|
if (IS_ERR(info->regs))
|
||||||
return -ENXIO;
|
return PTR_ERR(info->regs);
|
||||||
|
|
||||||
info->mclk = clk_get(&pdev->dev, "mclk");
|
info->mclk = clk_get(&pdev->dev, "mclk");
|
||||||
if (IS_ERR(info->mclk)) {
|
if (IS_ERR(info->mclk)) {
|
||||||
|
|
|
@ -361,9 +361,9 @@ static int jz4740_codec_probe(struct platform_device *pdev)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
||||||
base = devm_request_and_ioremap(&pdev->dev, mem);
|
base = devm_ioremap_resource(&pdev->dev, mem);
|
||||||
if (!base)
|
if (IS_ERR(base))
|
||||||
return -EBUSY;
|
return PTR_ERR(base);
|
||||||
|
|
||||||
jz4740_codec->regmap = devm_regmap_init_mmio(&pdev->dev, base,
|
jz4740_codec->regmap = devm_regmap_init_mmio(&pdev->dev, base,
|
||||||
&jz4740_codec_regmap_config);
|
&jz4740_codec_regmap_config);
|
||||||
|
|
|
@ -252,9 +252,9 @@ static int imx_audmux_probe(struct platform_device *pdev)
|
||||||
of_match_device(imx_audmux_dt_ids, &pdev->dev);
|
of_match_device(imx_audmux_dt_ids, &pdev->dev);
|
||||||
|
|
||||||
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
||||||
audmux_base = devm_request_and_ioremap(&pdev->dev, res);
|
audmux_base = devm_ioremap_resource(&pdev->dev, res);
|
||||||
if (!audmux_base)
|
if (IS_ERR(audmux_base))
|
||||||
return -EADDRNOTAVAIL;
|
return PTR_ERR(audmux_base);
|
||||||
|
|
||||||
pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
|
pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
|
||||||
if (IS_ERR(pinctrl)) {
|
if (IS_ERR(pinctrl)) {
|
||||||
|
|
|
@ -550,10 +550,9 @@ static int imx_ssi_probe(struct platform_device *pdev)
|
||||||
goto failed_get_resource;
|
goto failed_get_resource;
|
||||||
}
|
}
|
||||||
|
|
||||||
ssi->base = devm_request_and_ioremap(&pdev->dev, res);
|
ssi->base = devm_ioremap_resource(&pdev->dev, res);
|
||||||
if (!ssi->base) {
|
if (IS_ERR(ssi->base)) {
|
||||||
dev_err(&pdev->dev, "ioremap failed\n");
|
ret = PTR_ERR(ssi->base);
|
||||||
ret = -ENODEV;
|
|
||||||
goto failed_register;
|
goto failed_register;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -472,11 +472,9 @@ static int kirkwood_i2s_dev_probe(struct platform_device *pdev)
|
||||||
return -ENXIO;
|
return -ENXIO;
|
||||||
}
|
}
|
||||||
|
|
||||||
priv->io = devm_request_and_ioremap(&pdev->dev, mem);
|
priv->io = devm_ioremap_resource(&pdev->dev, mem);
|
||||||
if (!priv->io) {
|
if (IS_ERR(priv->io))
|
||||||
dev_err(&pdev->dev, "devm_request_and_ioremap failed\n");
|
return PTR_ERR(priv->io);
|
||||||
return -ENOMEM;
|
|
||||||
}
|
|
||||||
|
|
||||||
priv->irq = platform_get_irq(pdev, 0);
|
priv->irq = platform_get_irq(pdev, 0);
|
||||||
if (priv->irq <= 0) {
|
if (priv->irq <= 0) {
|
||||||
|
|
|
@ -724,11 +724,9 @@ static int mxs_saif_probe(struct platform_device *pdev)
|
||||||
|
|
||||||
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
||||||
|
|
||||||
saif->base = devm_request_and_ioremap(&pdev->dev, iores);
|
saif->base = devm_ioremap_resource(&pdev->dev, iores);
|
||||||
if (!saif->base) {
|
if (IS_ERR(saif->base))
|
||||||
dev_err(&pdev->dev, "ioremap failed\n");
|
return PTR_ERR(saif->base);
|
||||||
return -ENODEV;
|
|
||||||
}
|
|
||||||
|
|
||||||
dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0);
|
dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0);
|
||||||
if (!dmares) {
|
if (!dmares) {
|
||||||
|
|
|
@ -429,9 +429,9 @@ static int asoc_mmp_sspa_probe(struct platform_device *pdev)
|
||||||
if (res == NULL)
|
if (res == NULL)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
priv->sspa->mmio_base = devm_request_and_ioremap(&pdev->dev, res);
|
priv->sspa->mmio_base = devm_ioremap_resource(&pdev->dev, res);
|
||||||
if (priv->sspa->mmio_base == NULL)
|
if (IS_ERR(priv->sspa->mmio_base))
|
||||||
return -ENODEV;
|
return PTR_ERR(priv->sspa->mmio_base);
|
||||||
|
|
||||||
priv->sspa->clk = devm_clk_get(&pdev->dev, NULL);
|
priv->sspa->clk = devm_clk_get(&pdev->dev, NULL);
|
||||||
if (IS_ERR(priv->sspa->clk))
|
if (IS_ERR(priv->sspa->clk))
|
||||||
|
|
Loading…
Add table
Reference in a new issue