evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Staging: ipack: delete the call to remove() in ipack_driver_register

Browse source 
When a bus driver calls ipack_driver_register(), it should manages the returning
NULL value to undo all the operations it did before this call, and print the
corresponding trace.

It is not a task for the ipack driver to call the remove() function here.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Samuel Iglesias Gonsalvez 2012-05-25 10:03:02 +02:00 • committed by Greg Kroah-Hartman
parent 3b86bb2e11
commit b2bc13c5e0
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/ipack/ipack.c
View file

@ -141,8 +141,6 @@ struct ipack_device *ipack_device_register(struct ipack_bus_device *bus,
ret = device_register(&dev->dev); ret = device_register(&dev->dev);
if (ret < 0) { if (ret < 0) {
pr_err("error registering the device.\n");
dev->driver->ops->remove(dev);
kfree(dev); kfree(dev);
return NULL; return NULL;
} }