evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: speakup: fix memory leak

Browse source 
speakup_init() didn't free first_console if speakup_kobj_init() fails.
Also propagate speakup_kobj_init()'s return code.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Vasiliy Kulikov 2010-10-17 18:51:57 +04:00 • committed by Greg Kroah-Hartman
parent 6a56486716
commit b3495cebaa
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/staging/speakup/main.c
View file

@ -2259,8 +2259,11 @@ static int __init speakup_init(void)
first_console = kzalloc(sizeof(*first_console), GFP_KERNEL); first_console = kzalloc(sizeof(*first_console), GFP_KERNEL);
if (!first_console) if (!first_console)
return -ENOMEM; return -ENOMEM;
if (speakup_kobj_init() < 0) err = speakup_kobj_init();
return -ENOMEM; if (err) {
kfree(first_console);
return err;
}
reset_default_chars(); reset_default_chars();
reset_default_chartab(); reset_default_chartab();