evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: lustre: fix return value check in capa_hmac()

Browse source 
In case of error, the function crypto_alloc_hash() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2013-12-20 11:41:11 +08:00 • committed by Greg Kroah-Hartman
parent a3c383c5c3
commit b751bc77be
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/lustre/lustre/obdclass/capa.c
View file

@ -272,10 +272,10 @@ int capa_hmac(__u8 *hmac, struct lustre_capa *capa, __u8 *key)
alg = &capa_hmac_algs[capa_alg(capa)]; alg = &capa_hmac_algs[capa_alg(capa)];
tfm = crypto_alloc_hash(alg->ha_name, 0, 0); tfm = crypto_alloc_hash(alg->ha_name, 0, 0);
if (!tfm) { if (IS_ERR(tfm)) {
CERROR("crypto_alloc_tfm failed, check whether your kernel" CERROR("crypto_alloc_tfm failed, check whether your kernel"
"has crypto support!\n"); "has crypto support!\n");
return -ENOMEM; return PTR_ERR(tfm);
} }
keylen = alg->ha_keylen; keylen = alg->ha_keylen;