evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

KVM: fix error handling for out of range irq

Browse source 
find_index_from_host_irq returns 0 on error
but callers assume < 0 on error. This should
not matter much: an out of range irq should never happen since
irq handler was registered with this irq #,
and even if it does we get a spurious msix irq in guest
and typically nothing terrible happens.

Still, better to make it consistent.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
This commit is contained in:
Michael S. Tsirkin 2012-01-18 20:07:09 +02:00 • committed by Avi Kivity
parent e2358851ef
commit b93a355327
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
virt/kvm/assigned-dev.c
View file

@ -49,10 +49,8 @@ static int find_index_from_host_irq(struct kvm_assigned_dev_kernel
index = i; index = i;
break; break;
} }
if (index < 0) { if (index < 0)
printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n"); printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n");
return 0;
}
return index; return index;
} }