From b9ffa0f20ecdd943a7f38b6ba6a8c6a5403f400a Mon Sep 17 00:00:00 2001 From: Siba Prasad Date: Wed, 10 May 2017 12:22:07 +0530 Subject: [PATCH] scsi: ufs: ufs-qcom-ice: Initialize local variable in ice_cfg_start() Previously local variable ice_set in ufs_qcom_ice_cfg_start() function was initialized only if qcom_host->ice.vops->config_start was set. If that was not set, then the uninitialized value of ice_set might have lead to incorrect configuration of ICE. So initialize the variable regardless the value of config_start. Change-Id: I16692902d9f5b8df00ae2ffc7c363413d13e932a Signed-off-by: Siba Prasad --- drivers/scsi/ufs/ufs-qcom-ice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufs-qcom-ice.c b/drivers/scsi/ufs/ufs-qcom-ice.c index 814d1dcfe90e..0c862639fa3e 100644 --- a/drivers/scsi/ufs/ufs-qcom-ice.c +++ b/drivers/scsi/ufs/ufs-qcom-ice.c @@ -394,8 +394,8 @@ int ufs_qcom_ice_cfg_start(struct ufs_qcom_host *qcom_host, } + memset(&ice_set, 0, sizeof(ice_set)); if (qcom_host->ice.vops->config_start) { - memset(&ice_set, 0, sizeof(ice_set)); spin_lock_irqsave( &qcom_host->ice_work_lock, flags);