evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "spi: spi_qsd: Check device state during set_cs call"

Browse source 
This revert commit 67e815c616 ("spi: spi_qsd: Check device
state during set_cs call")

CRs Fixed: 2033878
Change-Id: I34a4564b8164230a6bd8b1ca4271c39a01d0b157
Signed-off-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
This commit is contained in:
Mukesh Kumar Savaliya 2017-04-18 18:05:44 +05:30
parent 7f0d77b390
commit bf1e13f6f7
1 changed files with 38 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
drivers/spi/spi_qsd.c
View file

@ -1496,9 +1496,9 @@ static inline void msm_spi_set_cs(struct spi_device *spi, bool set_flag)
u32 spi_ioc_orig; u32 spi_ioc_orig;
int rc; int rc;
if (dd->suspended) { rc = pm_runtime_get_sync(dd->dev);
dev_err(dd->dev, "%s: SPI operational state not valid %d\n", if (rc < 0) {
__func__, dd->suspended); dev_err(dd->dev, "Failure during runtime get");
return; return;
} }
@ -1524,6 +1524,8 @@ static inline void msm_spi_set_cs(struct spi_device *spi, bool set_flag)
writel_relaxed(spi_ioc, dd->base + SPI_IO_CONTROL); writel_relaxed(spi_ioc, dd->base + SPI_IO_CONTROL);
if (dd->pdata->is_shared) if (dd->pdata->is_shared)
put_local_resources(dd); put_local_resources(dd);
pm_runtime_mark_last_busy(dd->dev);
pm_runtime_put_autosuspend(dd->dev);
} }
static void reset_core(struct msm_spi *dd) static void reset_core(struct msm_spi *dd)
@ -1707,16 +1709,23 @@ static int msm_spi_prepare_transfer_hardware(struct spi_master *master)
struct msm_spi *dd = spi_master_get_devdata(master); struct msm_spi *dd = spi_master_get_devdata(master);
int resume_state = 0; int resume_state = 0;
if (!pm_runtime_enabled(dd->dev)) {
dev_err(dd->dev, "Runtime PM not available\n");
resume_state = -EBUSY;
goto spi_finalize;
}
resume_state = pm_runtime_get_sync(dd->dev); resume_state = pm_runtime_get_sync(dd->dev);
if (resume_state < 0) if (resume_state < 0)
goto spi_finalize; goto spi_finalize;
/*
* Counter-part of system-suspend when runtime-pm is not enabled.
* This way, resume can be left empty and device will be put in
* active mode only if client requests anything on the bus
*/
if (!pm_runtime_enabled(dd->dev))
resume_state = msm_spi_pm_resume_runtime(dd->dev);
if (resume_state < 0)
goto spi_finalize;
if (dd->suspended) {
resume_state = -EBUSY;
goto spi_finalize;
}
return 0; return 0;
spi_finalize: spi_finalize:
@ -1728,11 +1737,6 @@ static int msm_spi_unprepare_transfer_hardware(struct spi_master *master)
{ {
struct msm_spi *dd = spi_master_get_devdata(master); struct msm_spi *dd = spi_master_get_devdata(master);
if (!pm_runtime_enabled(dd->dev)) {
dev_err(dd->dev, "Runtime PM not available\n");
return -EBUSY;
}
pm_runtime_mark_last_busy(dd->dev); pm_runtime_mark_last_busy(dd->dev);
pm_runtime_put_autosuspend(dd->dev); pm_runtime_put_autosuspend(dd->dev);
return 0; return 0;
@ -2672,10 +2676,27 @@ resume_exit:
#ifdef CONFIG_PM_SLEEP #ifdef CONFIG_PM_SLEEP
static int msm_spi_suspend(struct device *device) static int msm_spi_suspend(struct device *device)
{ {
if (!pm_runtime_status_suspended(device)) { if (!pm_runtime_enabled(device) || !pm_runtime_suspended(device)) {
dev_err(device, "Runtime not suspended, deny sys suspend"); struct platform_device *pdev = to_platform_device(device);
return -EBUSY; struct spi_master *master = platform_get_drvdata(pdev);
struct msm_spi *dd;
dev_dbg(device, "system suspend");
if (!master)
goto suspend_exit;
dd = spi_master_get_devdata(master);
if (!dd)
goto suspend_exit;
msm_spi_pm_suspend_runtime(device);
/*
* set the device's runtime PM status to 'suspended'
*/
pm_runtime_disable(device);
pm_runtime_set_suspended(device);
pm_runtime_enable(device);
} }
suspend_exit:
return 0; return 0;
} }