evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rhashtable-test: Get rid of ptr in test_obj structure

Browse source 
This only blows up the size of the test structure for no gain
in test coverage. Reduces size of test_obj from 24 to 16 bytes.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Thomas Graf 2015-04-30 22:37:42 +00:00 • committed by David S. Miller
parent 1aa661f5c3
commit c2c8a90166
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/test_rhashtable.c
View file

@ -22,7 +22,6 @@
#include <linux/slab.h> #include <linux/slab.h>
#define TEST_PTR ((void *) 0xdeadbeef)
#define MAX_ENTRIES 1000000 #define MAX_ENTRIES 1000000
static int entries = 50000; static int entries = 50000;
@ -46,7 +45,6 @@ module_param(size, int, 0);
MODULE_PARM_DESC(size, "Initial size hint of table (default: 8)"); MODULE_PARM_DESC(size, "Initial size hint of table (default: 8)");
struct test_obj { struct test_obj {
void *ptr;
int value; int value;
struct rhash_head node; struct rhash_head node;
}; };
@ -78,9 +76,9 @@ static int __init test_rht_lookup(struct rhashtable *ht)
key); key);
return -EEXIST; return -EEXIST;
} else if (expected && obj) { } else if (expected && obj) {
if (obj->ptr != TEST_PTR || obj->value != i) { if (obj->value != i) {
pr_warn("Test failed: Lookup value mismatch %p!=%p, %u!=%u\n", pr_warn("Test failed: Lookup value mismatch %u!=%u\n",
obj->ptr, TEST_PTR, obj->value, i); obj->value, i);
return -EINVAL; return -EINVAL;
} }
} }
@ -153,7 +151,6 @@ static s64 __init test_rhashtable(struct rhashtable *ht)
goto error; goto error;
} }
obj->ptr = TEST_PTR;
obj->value = i * 2; obj->value = i * 2;
err = rhashtable_insert_fast(ht, &obj->node, test_rht_params); err = rhashtable_insert_fast(ht, &obj->node, test_rht_params);