evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[media] em28xx-cards: properly initialize the device bitmap

Browse source 
Instead of just creating a long int, use DECLARE_BITMAP().

No functional changes.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
This commit is contained in:
Mauro Carvalho Chehab 2014-01-14 17:35:15 -03:00
parent f52e9828d5
commit c3aed26218
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/media/usb/em28xx/em28xx-cards.c
View file

@ -66,7 +66,7 @@ MODULE_PARM_DESC(usb_xfer_mode,
/* Bitmask marking allocated devices from 0 to EM28XX_MAXBOARDS - 1 */ /* Bitmask marking allocated devices from 0 to EM28XX_MAXBOARDS - 1 */
static unsigned long em28xx_devused; DECLARE_BITMAP(em28xx_devused, EM28XX_MAXBOARDS);
struct em28xx_hash_table { struct em28xx_hash_table {
unsigned long hash; unsigned long hash;
@ -2885,7 +2885,7 @@ void em28xx_release_resources(struct em28xx *dev)
usb_put_dev(dev->udev); usb_put_dev(dev->udev);
/* Mark device as unused */ /* Mark device as unused */
clear_bit(dev->devno, &em28xx_devused); clear_bit(dev->devno, em28xx_devused);
mutex_unlock(&dev->lock); mutex_unlock(&dev->lock);
}; };
@ -3094,7 +3094,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
/* Check to see next free device and mark as used */ /* Check to see next free device and mark as used */
do { do {
nr = find_first_zero_bit(&em28xx_devused, EM28XX_MAXBOARDS); nr = find_first_zero_bit(em28xx_devused, EM28XX_MAXBOARDS);
if (nr >= EM28XX_MAXBOARDS) { if (nr >= EM28XX_MAXBOARDS) {
/* No free device slots */ /* No free device slots */
printk(DRIVER_NAME ": Supports only %i em28xx boards.\n", printk(DRIVER_NAME ": Supports only %i em28xx boards.\n",
@ -3102,7 +3102,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
retval = -ENOMEM; retval = -ENOMEM;
goto err_no_slot; goto err_no_slot;
} }
} while (test_and_set_bit(nr, &em28xx_devused)); } while (test_and_set_bit(nr, em28xx_devused));
/* Don't register audio interfaces */ /* Don't register audio interfaces */
if (interface->altsetting[0].desc.bInterfaceClass == USB_CLASS_AUDIO) { if (interface->altsetting[0].desc.bInterfaceClass == USB_CLASS_AUDIO) {
@ -3355,7 +3355,7 @@ err_free:
kfree(dev); kfree(dev);
err: err:
clear_bit(nr, &em28xx_devused); clear_bit(nr, em28xx_devused);
err_no_slot: err_no_slot:
usb_put_dev(udev); usb_put_dev(udev);