evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

msm: kgsl: Prevent race condition when freeing memory

Browse source 
Add a check to set the pending_free flag if it is not already
set before freeing sparse memory entry. This is required to
prevent multiple ioctl threads from freeing the same sparse
memory entry.

Change-Id: I4e2bbe6fcd98c58d36340c4f87cdff27fc1de22e
Signed-off-by: Deepak Kumar <dkumar@codeaurora.org>
This commit is contained in:
Deepak Kumar 2018-02-16 11:46:26 +05:30 • committed by Gerrit - the friendly Code Review server
parent 3f33435ef1
commit c4e16abf94
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/gpu/msm/kgsl.c
View file

@ -3356,7 +3356,13 @@ long kgsl_ioctl_sparse_phys_free(struct kgsl_device_private *dev_priv,
if (entry == NULL) if (entry == NULL)
return -EINVAL; return -EINVAL;
if (!kgsl_mem_entry_set_pend(entry)) {
kgsl_mem_entry_put(entry);
return -EBUSY;
}
if (entry->memdesc.cur_bindings != 0) { if (entry->memdesc.cur_bindings != 0) {
kgsl_mem_entry_unset_pend(entry);
kgsl_mem_entry_put(entry); kgsl_mem_entry_put(entry);
return -EINVAL; return -EINVAL;
} }
@ -3425,7 +3431,13 @@ long kgsl_ioctl_sparse_virt_free(struct kgsl_device_private *dev_priv,
if (entry == NULL) if (entry == NULL)
return -EINVAL; return -EINVAL;
if (!kgsl_mem_entry_set_pend(entry)) {
kgsl_mem_entry_put(entry);
return -EBUSY;
}
if (entry->bind_tree.rb_node != NULL) { if (entry->bind_tree.rb_node != NULL) {
kgsl_mem_entry_unset_pend(entry);
kgsl_mem_entry_put(entry); kgsl_mem_entry_put(entry);
return -EINVAL; return -EINVAL;
} }