evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

thermal: tsens: Switch from usleep_range() to msleep

Browse source 
On certain cases we have seen usleep_range() return before
the intended minimum time parameter passed to this function.
There is no protection against wakeups and we may return
early. msleep() already has code to handle this cases since
it loops as long as there is still time.

Change-Id: I3cf1e2d7f61f5a6d42d66afb86ae3b3fe141a9e7
Signed-off-by: Siddartha Mohanadoss <smohanad@codeaurora.org>
This commit is contained in:
Siddartha Mohanadoss 2017-01-04 18:25:54 -08:00
parent 2116b44bd3
commit c5fd9dbe9d
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/thermal/msm-tsens.c
View file

@ -170,10 +170,8 @@
#define TSENS_DEBUG_OFFSET_WORD3 0xc
#define TSENS_DEBUG_OFFSET_ROW 0x10
#define TSENS_DEBUG_DECIDEGC -950
#define TSENS_DEBUG_MIN_CYCLE 63000
#define TSENS_DEBUG_MAX_CYCLE 64000
#define TSENS_DEBUG_POLL_MIN 200000
#define TSENS_DEBUG_POLL_MAX 210000
#define TSENS_DEBUG_CYCLE_MS 64
#define TSENS_DEBUG_POLL_MS 200
#define TSENS_DEBUG_BUS_ID2_MIN_CYCLE 50
#define TSENS_DEBUG_BUS_ID2_MAX_CYCLE 51
#define TSENS_DEBUG_ID_MASK_1_4 0xffffffe1
@ -1412,8 +1410,7 @@ static void tsens_poll(struct work_struct *work)
spin_unlock_irqrestore(&tmdev->tsens_crit_lock, flags);
if (tmdev->tsens_critical_poll) {
usleep_range(TSENS_DEBUG_POLL_MIN,
TSENS_DEBUG_POLL_MAX);
msleep(TSENS_DEBUG_POLL_MS);
sensor_status_addr = TSENS_TM_SN_STATUS(tmdev->tsens_addr);
spin_lock_irqsave(&tmdev->tsens_crit_lock, flags);
@ -1567,8 +1564,7 @@ debug_start:
offset += TSENS_DEBUG_OFFSET_ROW;
}
loop++;
usleep_range(TSENS_DEBUG_MIN_CYCLE,
TSENS_DEBUG_MAX_CYCLE);
msleep(TSENS_DEBUG_CYCLE_MS);
}
BUG();
}