evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

usb: gadget: f_ncm: fix missing unlock on error in ncm_alloc()

Browse source 
Add the missing unlock before return from function ncm_alloc()
in the error handling case.

Introduced by commit e730660378.
(usb: gadget: f_ncm: add configfs support)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2013-06-18 11:43:29 +08:00 • committed by Greg Kroah-Hartman
parent 2a98dbbcd7
commit c92834c19f
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/usb/gadget/f_ncm.c
View file

@ -1403,6 +1403,7 @@ struct usb_function *ncm_alloc(struct usb_function_instance *fi)
sizeof(ncm->ethaddr)); sizeof(ncm->ethaddr));
if (status < 12) { /* strlen("01234567890a") */ if (status < 12) { /* strlen("01234567890a") */
kfree(ncm); kfree(ncm);
mutex_unlock(&opts->lock);
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
} }
ncm_string_defs[STRING_MAC_IDX].s = ncm->ethaddr; ncm_string_defs[STRING_MAC_IDX].s = ncm->ethaddr;