pktgen: Fix grammar errors and some poor wording in documentation · ca5b542cce - evie/android_kernel_oneplus_msm8998 - Gay Catgirls Forgejo: gay catgirls having sex

evie/android_kernel_oneplus_msm8998

pktgen: Fix grammar errors and some poor wording in documentation

Thanks to Rob Jones for suggesting some of the changes.

Cc: Rob Jones <rob.jones@codethink.co.uk>
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

This commit is contained in:

Ben Hutchings

2015-02-24 02:31:52 +00:00

• committed by

David S. Miller

parent 98e688f405

commit ca5b542cce

1 changed files with 30 additions and 26 deletions

56

Documentation/networking/pktgen.txt

View file

                   HOWTO for the linux packet generator
                   ------------------------------------
-Enable CONFIG_NET_PKTGEN to compile and build pktgen.o either in kernel
+Enable CONFIG_NET_PKTGEN to compile and build pktgen.o either in-kernel
-or as module. Module is preferred. insmod pktgen if needed. Once running
+or as a module.  A module is preferred; insmod pktgen if needed.  Once
-pktgen creates a thread on each CPU where each thread has affinity to its CPU.
+running, pktgen creates a thread for each CPU with affinity to that CPU.
-Monitoring and controlling is done via /proc. Easiest to select a suitable
+Monitoring and controlling is done via /proc.  It is easiest to select a
-a sample script and configure.
+suitable sample script and configure that.
 On a dual CPU:
 Tuning NIC for max performance
 ==============================
-The default NIC setting are (likely) not tuned for pktgen's artificial
+The default NIC settings are (likely) not tuned for pktgen's artificial
 overload type of benchmarking, as this could hurt the normal use-case.
 Specifically increasing the TX ring buffer in the NIC:
 A larger TX ring can improve pktgen's performance, while it can hurt
 in the general case, 1) because the TX ring buffer might get larger
-than the CPUs L1/L2 cache, 2) because it allow more queueing in the
+than the CPU's L1/L2 cache, 2) because it allows more queueing in the
 NIC HW layer (which is bad for bufferbloat).
-One should be careful to conclude, that packets/descriptors in the HW
+One should hesitate to conclude that packets/descriptors in the HW
 TX ring cause delay.  Drivers usually delay cleaning up the
-ring-buffers (for various performance reasons), thus packets stalling
+ring-buffers for various performance reasons, and packets stalling
-the TX ring, might just be waiting for cleanup.
+the TX ring might just be waiting for cleanup.
-This cleanup issues is specifically the case, for the driver ixgbe
+This cleanup issue is specifically the case for the driver ixgbe
-(Intel 82599 chip).  This driver (ixgbe) combine TX+RX ring cleanups,
+(Intel 82599 chip).  This driver (ixgbe) combines TX+RX ring cleanups,
 and the cleanup interval is affected by the ethtool --coalesce setting
 of parameter "rx-usecs".
-For ixgbe use e.g "30" resulting in approx 33K interrupts/sec (1/30*10^6):
+For ixgbe use e.g. "30" resulting in approx 33K interrupts/sec (1/30*10^6):
  # ethtool -C ethX rx-usecs 30
 Stopped: eth1
 Result: OK: max_before_softirq=10000
-Most important the devices assigned to thread. Note! A device can only belong
+Most important are the devices assigned to the thread.  Note that a
-to one thread.
+device can only belong to one thread.
 Viewing devices
 ===============
-Parm section holds configured info. Current hold running stats.
+The Params section holds configured information.  The Current section
-Result is printed after run or after interruption. Example:
+holds running statistics.  The Result is printed after a run or after
+interruption.  Example:
 /proc/net/pktgen/eth1
 Configuring threads and devices
 ================================
-This is done via the /proc interface easiest done via pgset in the scripts
+This is done via the /proc interface, and most easily done via pgset in
+the scripts.
 Examples:
 Example scripts
 ===============
-A collection of small tutorial scripts for pktgen is in examples dir.
+A collection of small tutorial scripts for pktgen is in the examples
+directory:
 pktgen.conf-1-1                  # 1 CPU 1 dev
 pktgen.conf-1-2                  # 1 CPU 2 dev
 pktgen.conf-1-1-ip6-rdos         # 1 CPU 1 dev ipv6  w. route DoS
 pktgen.conf-1-1-flows            # 1 CPU 1 dev multiple flows.
-Run in shell: ./pktgen.conf-X-Y It does all the setup including sending.
+Run in shell: ./pktgen.conf-X-Y
+This does all the setup including sending.
 Interrupt affinity
 ===================
-Note when adding devices to a specific CPU there good idea to also assign
+Note that when adding devices to a specific CPU it is a good idea to
-/proc/irq/XX/smp_affinity so the TX-interrupts gets bound to the same CPU.
+also assign /proc/irq/XX/smp_affinity so that the TX interrupts are bound
-as this reduces cache bouncing when freeing skb's.
+to the same CPU.  This reduces cache bouncing when freeing skbs.
 Enable IPsec
 ============
-Default IPsec transformation with ESP encapsulation plus Transport mode
+Default IPsec transformation with ESP encapsulation plus transport mode
-could be enabled by simply setting:
+can be enabled by simply setting:
 pgset "flag IPSEC"
 pgset "flows 1"
 To avoid breaking existing testbed scripts for using AH type and tunnel mode,
-user could use "pgset spi SPI_VALUE" to specify which formal of transformation
+you can use "pgset spi SPI_VALUE" to specify which transformation mode
 to employ.