From fa138cc53caa5e0542a7abd952e15aca475d722b Mon Sep 17 00:00:00 2001 From: Yue Ma Date: Tue, 27 Mar 2018 15:20:26 -0700 Subject: [PATCH] cnss2: Fix dereference before NULL check issue In cnss_mhi_notify_status(), NULL check should be performed before dereference for pci_priv. Change-Id: Iea5a6e2b8be9b07c235b02bfe02292f24da882d8 Signed-off-by: Yue Ma --- drivers/net/wireless/cnss2/pci.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/cnss2/pci.c b/drivers/net/wireless/cnss2/pci.c index 39deddd4db07..6078fd65fb49 100644 --- a/drivers/net/wireless/cnss2/pci.c +++ b/drivers/net/wireless/cnss2/pci.c @@ -1177,11 +1177,15 @@ void cnss_pci_clear_dump_info(struct cnss_pci_data *pci_priv) static void cnss_mhi_notify_status(enum MHI_CB_REASON reason, void *priv) { struct cnss_pci_data *pci_priv = priv; - struct cnss_plat_data *plat_priv = pci_priv->plat_priv; + struct cnss_plat_data *plat_priv; enum cnss_recovery_reason cnss_reason = CNSS_REASON_RDDM; - if (!pci_priv) + if (!pci_priv) { + cnss_pr_err("pci_priv is NULL"); return; + } + + plat_priv = pci_priv->plat_priv; cnss_pr_dbg("MHI status cb is called with reason %d\n", reason);