evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tehuti: return -EFAULT on copy_to_user errors

Browse source 
copy_to_user() returns the number of bytes remaining but we want to
return a negative error code here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2010-06-03 00:05:35 +00:00 • committed by David S. Miller
parent 60a5711db6
commit d233807018
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/tehuti.c
View file

@ -646,7 +646,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)
error = copy_from_user(data, ifr->ifr_data, sizeof(data)); error = copy_from_user(data, ifr->ifr_data, sizeof(data));
if (error) { if (error) {
pr_err("cant copy from user\n"); pr_err("cant copy from user\n");
RET(error); RET(-EFAULT);
} }
DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]); DBG("%d 0x%x 0x%x\n", data[0], data[1], data[2]);
} }
@ -665,7 +665,7 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)
data[2]); data[2]);
error = copy_to_user(ifr->ifr_data, data, sizeof(data)); error = copy_to_user(ifr->ifr_data, data, sizeof(data));
if (error) if (error)
RET(error); RET(-EFAULT);
break; break;
case BDX_OP_WRITE: case BDX_OP_WRITE: