evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

seemp: fix code analysis issues

Browse source 
Fix code analysis issues related to seemp, such as, variables might
be used uninitialized, and array may use index values larger than its
size.

Change-Id: Ic537ece4d00ac3d72d679359b60999df473f8710
Signed-off-by: Yida Wang <yidaw@codeaurora.org>
This commit is contained in:
Yida Wang 2017-04-05 15:32:36 -04:00
parent c5751be200
commit d45e41bf0c
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/platform/msm/seemp_core/seemp_logk.c
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2014-2015, The Linux Foundation. All rights reserved. * Copyright (c) 2014-2015, 2017, The Linux Foundation. All rights reserved.
* *
* This program is free software; you can redistribute it and/or modify * This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 and * it under the terms of the GNU General Public License version 2 and
@ -184,6 +184,8 @@ static int seemp_logk_usr_record(const char __user *buf, size_t count)
if (copy_from_user(&usr_blk.payload, &local_blk->payload, if (copy_from_user(&usr_blk.payload, &local_blk->payload,
sizeof(struct blk_payload)) != 0) sizeof(struct blk_payload)) != 0)
return -EFAULT; return -EFAULT;
} else {
return -EFAULT;
} }
idx = ret = 0; idx = ret = 0;
now = current_kernel_time(); now = current_kernel_time();
@ -283,7 +285,12 @@ static bool seemp_logk_get_bit_from_vector(__u8 *pVec, __u32 index)
{ {
unsigned int byte_num = index/8; unsigned int byte_num = index/8;
unsigned int bit_num = index%8; unsigned int bit_num = index%8;
unsigned char byte = pVec[byte_num]; unsigned char byte;
if (DIV_ROUND_UP(index, 8) > MASK_BUFFER_SIZE)
return false;
byte = pVec[byte_num];
return !(byte & (1 << bit_num)); return !(byte & (1 << bit_num));
} }