From d680dbcb3ab0573d4fb95114a13a2dae1a52a8ef Mon Sep 17 00:00:00 2001 From: Steve Muckle Date: Fri, 9 Mar 2012 11:15:24 -0800 Subject: [PATCH] checkpatch: recognize only specific tags when ending commit text There are some very frequently used tags that checkpatch can look for as an ending to the commit text rather than using a pattern, which can generate false positives in the "no commit text" rule. Change-Id: I5b4400017b8273bcd9f5a59b3e28965c0062bef4 Signed-off-by: Steve Muckle Signed-off-by: Stepan Moskovchenko --- scripts/checkpatch.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0b1da75d24c1..dbe77d70aa60 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2265,7 +2265,10 @@ sub process { "commit text line over " . SHORTTEXT_LIMIT . " characters\n" . $herecurr); - } elsif ($line=~/^\s*[\x21-\x39\x3b-\x7e]+:/) { + } elsif ($line=~/^\s*change-id:/i || + $line=~/^\s*signed-off-by:/i || + $line=~/^\s*crs-fixed:/i || + $line=~/^\s*acked-by:/i) { # this is a tag, there must be commit # text by now if ($commit_text_present == 0) {