evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: dt2817: use comedi_request_region()

Browse source 
Use comedi_request_region() to request the I/O region used by this
driver.

Remove the noise when the board is first attached as well as the
error message when the request_region() fails, comedi_request_reqion()
will output the error message if necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-04-09 16:19:26 -07:00 • committed by Greg Kroah-Hartman
parent 19b3da3e91
commit d6d0299000
1 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/staging/comedi/drivers/dt2817.c
View file

@ -126,15 +126,10 @@ static int dt2817_attach(struct comedi_device *dev, struct comedi_devconfig *it)
{ {
int ret; int ret;
struct comedi_subdevice *s; struct comedi_subdevice *s;
unsigned long iobase;
iobase = it->options[0]; ret = comedi_request_region(dev, it->options[0], DT2817_SIZE);
printk(KERN_INFO "comedi%d: dt2817: 0x%04lx ", dev->minor, iobase); if (ret)
if (!request_region(iobase, DT2817_SIZE, "dt2817")) { return ret;
printk("I/O port conflict\n");
return -EIO;
}
dev->iobase = iobase;
ret = comedi_alloc_subdevices(dev, 1); ret = comedi_alloc_subdevices(dev, 1);
if (ret) if (ret)
@ -153,8 +148,6 @@ static int dt2817_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->state = 0; s->state = 0;
outb(0, dev->iobase + DT2817_CR); outb(0, dev->iobase + DT2817_CR);
printk(KERN_INFO "\n");
return 0; return 0;
} }