evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NTB: correct stack usage warning in debugfs_read

Browse source 
Correct gcc warning of using too much stack debugfs_read.  This is done
by kmallocing the buffer instead of using the char array on stack.
Also, shrinking the buffer to something closer to what is currently
being used.

Signed-off-by: Jon Mason <jon.mason@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jon Mason 2013-01-19 02:02:25 -07:00 • committed by Greg Kroah-Hartman
parent f766755c30
commit d7237e22bb
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/ntb/ntb_transport.c
View file

@ -368,10 +368,14 @@ static ssize_t debugfs_read(struct file *filp, char __user *ubuf, size_t count,
loff_t *offp) loff_t *offp)
{ {
struct ntb_transport_qp *qp; struct ntb_transport_qp *qp;
char buf[1024]; char *buf;
ssize_t ret, out_offset, out_count; ssize_t ret, out_offset, out_count;
out_count = 1024; out_count = 600;
buf = kmalloc(out_count, GFP_KERNEL);
if (!buf)
return -ENOMEM;
qp = filp->private_data; qp = filp->private_data;
out_offset = 0; out_offset = 0;
@ -410,10 +414,13 @@ static ssize_t debugfs_read(struct file *filp, char __user *ubuf, size_t count,
"tx_mw_end - \t%p\n", qp->tx_mw_end); "tx_mw_end - \t%p\n", qp->tx_mw_end);
out_offset += snprintf(buf + out_offset, out_count - out_offset, out_offset += snprintf(buf + out_offset, out_count - out_offset,
"QP Link %s\n", (qp->qp_link == NTB_LINK_UP) ? "\nQP Link %s\n", (qp->qp_link == NTB_LINK_UP) ?
"Up" : "Down"); "Up" : "Down");
if (out_offset > out_count)
out_offset = out_count;
ret = simple_read_from_buffer(ubuf, count, offp, buf, out_offset); ret = simple_read_from_buffer(ubuf, count, offp, buf, out_offset);
kfree(buf);
return ret; return ret;
} }