evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

IEEE 802.15.4: remove get_bsn from "struct ieee802154_mlme_ops"

Browse source 
It served no purpose: we never call it from anywhere in the stack
and the only driver that did implement it (fakehard) merely provided
a dummy value.

There is also considerable doubt whether it would make sense to
even attempt beacon processing at this level in the Linux kernel.

Signed-off-by: Werner Almesberger <werner@almesberger.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Werner Almesberger 2013-04-04 06:32:12 +00:00 • committed by David S. Miller
parent 6b0ee8c036
commit d87c8c6d15
2 changed files with 0 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
drivers/net/ieee802154/fakehard.c
View file

@ -105,26 +105,6 @@ static u8 fake_get_dsn(const struct net_device *dev)
return 0x00; /* DSN are implemented in HW, so return just 0 */ return 0x00; /* DSN are implemented in HW, so return just 0 */
} }
/**
* fake_get_bsn - Retrieve the BSN of the device.
* @dev: The network device to retrieve the BSN for.
*
* Returns the IEEE 802.15.4 BSN for the network device.
* The BSN is the sequence number which will be added to each
* beacon frame sent by the MAC.
*
* BSN means 'Beacon Sequence Number'.
*
* Note: This is in section 7.2.1.2 of the IEEE 802.15.4-2006
* document.
*/
static u8 fake_get_bsn(const struct net_device *dev)
{
BUG_ON(dev->type != ARPHRD_IEEE802154);
return 0x00; /* BSN are implemented in HW, so return just 0 */
}
/** /**
* fake_assoc_req - Make an association request to the HW. * fake_assoc_req - Make an association request to the HW.
* @dev: The network device which we are associating to a network. * @dev: The network device which we are associating to a network.
@ -264,7 +244,6 @@ static struct ieee802154_mlme_ops fake_mlme = {
.get_pan_id = fake_get_pan_id, .get_pan_id = fake_get_pan_id,
.get_short_addr = fake_get_short_addr, .get_short_addr = fake_get_short_addr,
.get_dsn = fake_get_dsn, .get_dsn = fake_get_dsn,
.get_bsn = fake_get_bsn,
}; };
static int ieee802154_fake_open(struct net_device *dev) static int ieee802154_fake_open(struct net_device *dev)

1
include/net/ieee802154_netdev.h
View file

@ -110,7 +110,6 @@ struct ieee802154_mlme_ops {
u16 (*get_pan_id)(const struct net_device *dev); u16 (*get_pan_id)(const struct net_device *dev);
u16 (*get_short_addr)(const struct net_device *dev); u16 (*get_short_addr)(const struct net_device *dev);
u8 (*get_dsn)(const struct net_device *dev); u8 (*get_dsn)(const struct net_device *dev);
u8 (*get_bsn)(const struct net_device *dev);
}; };
/* The IEEE 802.15.4 standard defines 2 type of the devices: /* The IEEE 802.15.4 standard defines 2 type of the devices: