evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

HSI: nokia-modem: fix error handling of irq_of_parse_and_map

Browse source 
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
This commit is contained in:
Dmitry Torokhov 2014-11-14 14:06:37 -08:00 • committed by Sebastian Reichel
parent cdb83947ab
commit d95dc9e388
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/hsi/clients/nokia-modem.c
View file

@ -164,9 +164,9 @@ static int nokia_modem_probe(struct device *dev)
dev_set_drvdata(dev, modem); dev_set_drvdata(dev, modem);
irq = irq_of_parse_and_map(np, 0); irq = irq_of_parse_and_map(np, 0);
if (irq < 0) { if (!irq) {
dev_err(dev, "Invalid rst_ind interrupt (%d)\n", irq); dev_err(dev, "Invalid rst_ind interrupt (%d)\n", irq);
return irq; return -EINVAL;
} }
modem->nokia_modem_rst_ind_irq = irq; modem->nokia_modem_rst_ind_irq = irq;
pflags = irq_get_trigger_type(irq); pflags = irq_get_trigger_type(irq);