evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "qseecom: fix kclient free issue in qseecom_remove"

Browse source
This commit is contained in:
Linux Build Service Account 2018-09-21 09:14:44 -07:00 • committed by Gerrit - the friendly Code Review server
commit d97979c767
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/misc/qseecom.c
View file

@ -8743,11 +8743,11 @@ static int qseecom_remove(struct platform_device *pdev)
&qseecom.registered_kclient_list_head, list) { &qseecom.registered_kclient_list_head, list) {
/* Break the loop if client handle is NULL */ /* Break the loop if client handle is NULL */
if (!kclient->handle) if (!kclient->handle) {
goto exit_free_kclient; list_del(&kclient->list);
kzfree(kclient);
if (list_empty(&kclient->list)) break;
goto exit_free_kc_handle; }
list_del(&kclient->list); list_del(&kclient->list);
mutex_lock(&app_access_lock); mutex_lock(&app_access_lock);
@ -8760,11 +8760,6 @@ static int qseecom_remove(struct platform_device *pdev)
} }
} }
exit_free_kc_handle:
kzfree(kclient->handle);
exit_free_kclient:
kzfree(kclient);
spin_unlock_irqrestore(&qseecom.registered_kclient_list_lock, flags); spin_unlock_irqrestore(&qseecom.registered_kclient_list_lock, flags);
if (qseecom.qseos_version > QSEEE_VERSION_00) if (qseecom.qseos_version > QSEEE_VERSION_00)