[BNX2]: Block MII access when ifdown.
The device may be in D3hot state and should not allow MII register access. Signed-off-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
427c2196b9
commit
dad3e452da
1 changed files with 6 additions and 0 deletions
|
@ -5562,6 +5562,9 @@ bnx2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
|
||||||
case SIOCGMIIREG: {
|
case SIOCGMIIREG: {
|
||||||
u32 mii_regval;
|
u32 mii_regval;
|
||||||
|
|
||||||
|
if (!netif_running(dev))
|
||||||
|
return -EAGAIN;
|
||||||
|
|
||||||
spin_lock_bh(&bp->phy_lock);
|
spin_lock_bh(&bp->phy_lock);
|
||||||
err = bnx2_read_phy(bp, data->reg_num & 0x1f, &mii_regval);
|
err = bnx2_read_phy(bp, data->reg_num & 0x1f, &mii_regval);
|
||||||
spin_unlock_bh(&bp->phy_lock);
|
spin_unlock_bh(&bp->phy_lock);
|
||||||
|
@ -5575,6 +5578,9 @@ bnx2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
|
||||||
if (!capable(CAP_NET_ADMIN))
|
if (!capable(CAP_NET_ADMIN))
|
||||||
return -EPERM;
|
return -EPERM;
|
||||||
|
|
||||||
|
if (!netif_running(dev))
|
||||||
|
return -EAGAIN;
|
||||||
|
|
||||||
spin_lock_bh(&bp->phy_lock);
|
spin_lock_bh(&bp->phy_lock);
|
||||||
err = bnx2_write_phy(bp, data->reg_num & 0x1f, data->val_in);
|
err = bnx2_write_phy(bp, data->reg_num & 0x1f, data->val_in);
|
||||||
spin_unlock_bh(&bp->phy_lock);
|
spin_unlock_bh(&bp->phy_lock);
|
||||||
|
|
Loading…
Add table
Reference in a new issue