From df46a12ca75e6afe1caa3b36cc6c3e65c1a23c94 Mon Sep 17 00:00:00 2001 From: Zhiming Weng Date: Fri, 20 Oct 2017 15:58:25 +0800 Subject: [PATCH] msm: cec: simplify TX message processing Simplify the message processing of CEC adapter driver's transmit function. Don't need to decompose CEC message's header block and data block 0 before programming to the registers. Change-Id: Icf2b2f123bda560ef4e3c8c4c6a2eaf828b7ce9a CRs-Fixed: 2117559 Signed-off-by: Zhiming Weng --- drivers/media/platform/msm/sde/cec/sde_hdmi_cec.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/media/platform/msm/sde/cec/sde_hdmi_cec.c b/drivers/media/platform/msm/sde/cec/sde_hdmi_cec.c index f56d822ad335..d61bfdce1cef 100644 --- a/drivers/media/platform/msm/sde/cec/sde_hdmi_cec.c +++ b/drivers/media/platform/msm/sde/cec/sde_hdmi_cec.c @@ -159,17 +159,7 @@ static int sde_hdmi_cec_adap_transmit(struct cec_adapter *adap, u8 attempts, frame_type = cec_msg_is_broadcast(msg) ? BIT(0) : 0; - /* header block */ - CEC_REG_WRITE(hw, HDMI_CEC_WR_DATA, - (((cec_msg_initiator(msg) << 4) | - cec_msg_destination(msg)) << 8) | frame_type); - - /* data block 0 : opcode */ - CEC_REG_WRITE(hw, HDMI_CEC_WR_DATA, - ((msg->len < 2 ? 0 : cec_msg_opcode(msg)) << 8) | frame_type); - - /* data block 1-14 : operand 0-13 */ - for (i = 2; i < msg->len; i++) + for (i = 0; i < msg->len; i++) CEC_REG_WRITE(hw, HDMI_CEC_WR_DATA, (msg->msg[i] << 8) | frame_type);