evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

coresight: etm4x: Check every parameter used by dma_xx_coherent.

Browse source 
The dma_alloc_coherent return an "void *" not an "void __iomen *".
It uses the wrong parameters when calls dma_free_coherent function.

The sparse tool output logs as the following:
coresight-tmc.c:199:23:    expected void *<noident>
coresight-tmc.c:199:23:    got void [noderef] <asn:2>*vaddr
coresight-tmc.c:336:30: warning: incorrect type in assignment
(different address spaces)
coresight-tmc.c:336:30:    expected char *buf
coresight-tmc.c:336:30:    got void [noderef] <asn:2>*
coresight-tmc.c:769:50: warning: incorrect type in argument 4
(different base types)
coresight-tmc.c:769:50:    expected unsigned long long
[unsigned] [usertype] dma_handle
coresight-tmc.c:769:50:    got restricted gfp_t

Signed-off-by: Eric Long <eric.long@linaro.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 61390593f72377c3a8f41ef998462e2d3985adac)
This commit is contained in:
Eric Long 2016-02-17 17:51:44 -07:00 • committed by Mathieu Poirier
parent fea6fe15e3
commit e1e8321c38
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/hwtracing/coresight/coresight-tmc.c
View file

@ -124,7 +124,7 @@ struct tmc_drvdata {
bool reading; bool reading;
char *buf; char *buf;
dma_addr_t paddr; dma_addr_t paddr;
void __iomem *vaddr; void *vaddr;
u32 size; u32 size;
bool enable; bool enable;
enum tmc_config_type config_type; enum tmc_config_type config_type;
@ -766,7 +766,7 @@ err_misc_register:
err_devm_kzalloc: err_devm_kzalloc:
if (drvdata->config_type == TMC_CONFIG_TYPE_ETR) if (drvdata->config_type == TMC_CONFIG_TYPE_ETR)
dma_free_coherent(dev, drvdata->size, dma_free_coherent(dev, drvdata->size,
&drvdata->paddr, GFP_KERNEL); drvdata->vaddr, drvdata->paddr);
return ret; return ret;
} }