From e320afbfb14a96c441d3798113559439a87cc0ba Mon Sep 17 00:00:00 2001 From: Bryan Huntsman <bryanh@codeaurora.org> Date: Tue, 4 May 2010 17:31:32 -0700 Subject: [PATCH] scripts: checkpatch.pl: warn on invalid credentials @quicinc.com identities are not allowed. Check the "From:" field in the patch, equivalent to the author in the git commit, and the Signed-off-by field. Signed-off-by: Bryan Huntsman <bryanh@codeaurora.org> Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org> [imaund@codeaurora.org: Resolved context conflicts] Signed-off-by: Ian Maund <imaund@codeaurora.org> --- scripts/checkpatch.pl | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3eda411c042a..c45af9f9da2e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2312,6 +2312,10 @@ sub process { "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr); } } + if ($line =~ /^\s*signed-off-by:.*(quicinc|qualcomm)\.com/i) { + WARN("BAD_SIGN_OFF", + "invalid Signed-off-by identity\n" . $line ); + } # Check for duplicate signatures my $sig_nospace = $line; @@ -2442,6 +2446,11 @@ sub process { "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr); } +#check the patch for invalid author credentials + if ($line =~ /^From:.*(quicinc|qualcomm)\.com/) { + WARN("BAD_AUTHOR", "invalid author identity\n" . $line ); + } + # Check for wrappage within a valid hunk of the file if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { ERROR("CORRUPTED_PATCH",