evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: bcm: using time_after and time_before in InterfaceIdleMode.c

Browse source 
Used the time_after and time_before insted of comparing
the jiffies directly.This will fix the warnings and errors
found by the checkpatch.pl script.

Signed-off-by: Gokulnath Avanashilingam <Gokulnath.Avanashilingam@in.bosch.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Gokulnath Avanashilingam 2013-12-20 20:54:31 +05:30 • committed by Greg Kroah-Hartman
parent 786bdddc36
commit e42ff08dd9
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/staging/bcm/InterfaceIdleMode.c
View file

@ -56,7 +56,7 @@ int InterfaceIdleModeRespond(struct bcm_mini_adapter *Adapter,
int bytes; int bytes;
if (ntohl(*puiBuffer) == GO_TO_IDLE_MODE_PAYLOAD) { if (ntohl(*puiBuffer) == GO_TO_IDLE_MODE_PAYLOAD) {
if (ntohl(*(puiBuffer+1)) == 0 ) { if (ntohl(*(puiBuffer+1)) == 0) {
status = wrmalt (Adapter, SW_ABORT_IDLEMODE_LOC, status = wrmalt (Adapter, SW_ABORT_IDLEMODE_LOC,
&uiRegRead, sizeof(uiRegRead)); &uiRegRead, sizeof(uiRegRead));
@ -196,7 +196,7 @@ static int InterfaceAbortIdlemode(struct bcm_mini_adapter *Adapter,
/* mdelay(25); */ /* mdelay(25); */
timeout = jiffies + msecs_to_jiffies(50) ; timeout = jiffies + msecs_to_jiffies(50) ;
while ( timeout > jiffies ) { while (time_after(timeout, jiffies)) {
itr++ ; itr++ ;
rdmalt(Adapter, CHIP_ID_REG, &chip_id, sizeof(UINT)); rdmalt(Adapter, CHIP_ID_REG, &chip_id, sizeof(UINT));
if (0xbece3200 == (chip_id&~(0xF0))) if (0xbece3200 == (chip_id&~(0xF0)))
@ -204,7 +204,7 @@ static int InterfaceAbortIdlemode(struct bcm_mini_adapter *Adapter,
if (chip_id == Adapter->chip_id) if (chip_id == Adapter->chip_id)
break; break;
} }
if ( timeout < jiffies ) if (time_before(timeout, jiffies))
BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS,
IDLE_MODE, DBG_LVL_ALL, IDLE_MODE, DBG_LVL_ALL,
"Not able to read chip-id even after 25 msec"); "Not able to read chip-id even after 25 msec");