ASoC: fix debugfs directory creation bug
Avoid creating duplicate directories by prefixing codecs and platforms with their separate identifiers. This avoids snd-soc-dummy (which can appear both as a dummy platform and a dummy codec on the same card) from clashing. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Tested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
parent
7171511eae
commit
e73f3de5c5
1 changed files with 24 additions and 4 deletions
|
@ -270,12 +270,32 @@ static const struct file_operations codec_reg_fops = {
|
||||||
.llseek = default_llseek,
|
.llseek = default_llseek,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
static struct dentry *soc_debugfs_create_dir(struct dentry *parent,
|
||||||
|
const char *fmt, ...)
|
||||||
|
{
|
||||||
|
struct dentry *de;
|
||||||
|
va_list ap;
|
||||||
|
char *s;
|
||||||
|
|
||||||
|
va_start(ap, fmt);
|
||||||
|
s = kvasprintf(GFP_KERNEL, fmt, ap);
|
||||||
|
va_end(ap);
|
||||||
|
|
||||||
|
if (!s)
|
||||||
|
return NULL;
|
||||||
|
|
||||||
|
de = debugfs_create_dir(s, parent);
|
||||||
|
kfree(s);
|
||||||
|
|
||||||
|
return de;
|
||||||
|
}
|
||||||
|
|
||||||
static void soc_init_codec_debugfs(struct snd_soc_codec *codec)
|
static void soc_init_codec_debugfs(struct snd_soc_codec *codec)
|
||||||
{
|
{
|
||||||
struct dentry *debugfs_card_root = codec->card->debugfs_card_root;
|
struct dentry *debugfs_card_root = codec->card->debugfs_card_root;
|
||||||
|
|
||||||
codec->debugfs_codec_root = debugfs_create_dir(codec->name,
|
codec->debugfs_codec_root = soc_debugfs_create_dir(debugfs_card_root,
|
||||||
debugfs_card_root);
|
"codec:%s", codec->name);
|
||||||
if (!codec->debugfs_codec_root) {
|
if (!codec->debugfs_codec_root) {
|
||||||
dev_warn(codec->dev,
|
dev_warn(codec->dev,
|
||||||
"ASoC: Failed to create codec debugfs directory\n");
|
"ASoC: Failed to create codec debugfs directory\n");
|
||||||
|
@ -306,8 +326,8 @@ static void soc_init_platform_debugfs(struct snd_soc_platform *platform)
|
||||||
{
|
{
|
||||||
struct dentry *debugfs_card_root = platform->card->debugfs_card_root;
|
struct dentry *debugfs_card_root = platform->card->debugfs_card_root;
|
||||||
|
|
||||||
platform->debugfs_platform_root = debugfs_create_dir(platform->name,
|
platform->debugfs_platform_root = soc_debugfs_create_dir(debugfs_card_root,
|
||||||
debugfs_card_root);
|
"platform:%s", platform->name);
|
||||||
if (!platform->debugfs_platform_root) {
|
if (!platform->debugfs_platform_root) {
|
||||||
dev_warn(platform->dev,
|
dev_warn(platform->dev,
|
||||||
"ASoC: Failed to create platform debugfs directory\n");
|
"ASoC: Failed to create platform debugfs directory\n");
|
||||||
|
|
Loading…
Add table
Reference in a new issue