From e7549a9c25eed8fcb5735a40e289b35fa38c4ac8 Mon Sep 17 00:00:00 2001 From: Runmin Wang Date: Tue, 6 Sep 2016 16:07:30 -0700 Subject: [PATCH] soc: qcom: irq-helper: Add comments to exposed APIs Add comments and might_sleep() to warn that irq_blacklist_on/off APIs should not be called in atomic context. CRs-Fixed: 1063719 Change-Id: Ie6858243a666aeb21cc486208b9dd8221e9ad674 Signed-off-by: Runmin Wang --- drivers/soc/qcom/irq-helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/soc/qcom/irq-helper.c b/drivers/soc/qcom/irq-helper.c index 7bb371f7991e..370801291230 100644 --- a/drivers/soc/qcom/irq-helper.c +++ b/drivers/soc/qcom/irq-helper.c @@ -78,10 +78,12 @@ IRQ_HELPER_ATTR(irq_blacklist_on, 0444, show_deploy, NULL); static struct irq_helper *irq_h; +/* Do not call this API in an atomic context */ int irq_blacklist_on(void) { bool flag = false; + might_sleep(); if (!irq_h) { pr_err("%s: init function is not called", __func__); return -EPERM; @@ -103,10 +105,12 @@ int irq_blacklist_on(void) } EXPORT_SYMBOL(irq_blacklist_on); +/* Do not call this API in an atomic context */ int irq_blacklist_off(void) { bool flag = false; + might_sleep(); if (!irq_h) { pr_err("%s: init function is not called", __func__); return -EPERM;