evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[media] si2157: add own goto label for kfree() on probe error

Browse source 
Use own goto label for error case mem free is needed, even kfree could
be called with NULL. I think it is better to have it, even not required.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Antti Palosaari 2014-12-06 15:13:31 -03:00 • committed by Mauro Carvalho Chehab
parent c12922338c
commit e7f3f9f362
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/media/tuners/si2157.c
View file

@ -353,7 +353,7 @@ static int si2157_probe(struct i2c_client *client,
cmd.rlen = 1; cmd.rlen = 1;
ret = si2157_cmd_execute(client, &cmd); ret = si2157_cmd_execute(client, &cmd);
if (ret) if (ret)
goto err; goto err_kfree;
memcpy(&fe->ops.tuner_ops, &si2157_ops, sizeof(struct dvb_tuner_ops)); memcpy(&fe->ops.tuner_ops, &si2157_ops, sizeof(struct dvb_tuner_ops));
fe->tuner_priv = client; fe->tuner_priv = client;
@ -363,9 +363,11 @@ static int si2157_probe(struct i2c_client *client,
"Si2146" : "Si2147/2148/2157/2158"); "Si2146" : "Si2147/2148/2157/2158");
return 0; return 0;
err_kfree:
kfree(dev);
err: err:
dev_dbg(&client->dev, "failed=%d\n", ret); dev_dbg(&client->dev, "failed=%d\n", ret);
kfree(dev);
return ret; return ret;
} }