evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ASoC: change mask in snd_soc_get/put_volsw_sx to unsigned int

Browse source 
If the result of (min + max) is negative in functions
snd_soc_get_volsw_sx() or snd_soc_put_volsw_sx(), there
will be an overflow for the variable 'mask'.
   UBSAN: Undefined behaviour in sound/soc/soc-ops.c:382:6
   signed integer overflow:
   -2147483648 - 1 cannot be represented in type 'int'

Fix this by updating the variable type of 'mask' to unsigned int.

Change-Id: Ia34f397fad5b93c0e2ffacae60e051ad20c20bdf
Signed-off-by: Banajit Goswami <bgoswami@codeaurora.org>
This commit is contained in:
Banajit Goswami 2017-09-22 11:52:35 -07:00 • committed by Gerrit - the friendly Code Review server
parent 6380da4856
commit eca745fc5a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sound/soc/soc-ops.c
View file

@ -379,7 +379,7 @@ int snd_soc_get_volsw_sx(struct snd_kcontrol *kcontrol,
unsigned int rshift = mc->rshift; unsigned int rshift = mc->rshift;
int max = mc->max; int max = mc->max;
int min = mc->min; int min = mc->min;
int mask = (1 << (fls(min + max) - 1)) - 1; unsigned int mask = (1 << (fls(min + max) - 1)) - 1;
unsigned int val; unsigned int val;
int ret; int ret;
@ -424,7 +424,7 @@ int snd_soc_put_volsw_sx(struct snd_kcontrol *kcontrol,
unsigned int rshift = mc->rshift; unsigned int rshift = mc->rshift;
int max = mc->max; int max = mc->max;
int min = mc->min; int min = mc->min;
int mask = (1 << (fls(min + max) - 1)) - 1; unsigned int mask = (1 << (fls(min + max) - 1)) - 1;
int err = 0; int err = 0;
unsigned int val, val_mask, val2 = 0; unsigned int val, val_mask, val2 = 0;