evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf symbols: Set freed members to NULL in dso destructor

Browse source 
To help in debugging use after free bugs.

Reported-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-3ckwsob2g1q23s77nuhexrq7@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2013-12-10 15:26:55 -03:00
parent bf4414ae7b
commit ee021d4223
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tools/perf/util/dso.c
View file

@ -475,13 +475,23 @@ void dso__delete(struct dso *dso)
int i; int i;
for (i = 0; i < MAP__NR_TYPES; ++i) for (i = 0; i < MAP__NR_TYPES; ++i)
symbols__delete(&dso->symbols[i]); symbols__delete(&dso->symbols[i]);
if (dso->short_name_allocated)
if (dso->short_name_allocated) {
free((char *)dso->short_name); free((char *)dso->short_name);
if (dso->long_name_allocated) dso->short_name = NULL;
dso->short_name_allocated = false;
}
if (dso->long_name_allocated) {
free((char *)dso->long_name); free((char *)dso->long_name);
dso->long_name = NULL;
dso->long_name_allocated = false;
}
dso_cache__free(&dso->cache); dso_cache__free(&dso->cache);
dso__free_a2l(dso); dso__free_a2l(dso);
free(dso->symsrc_filename); free(dso->symsrc_filename);
dso->symsrc_filename = NULL;
free(dso); free(dso);
} }