evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[STRIP]: Fix neighbour table refcount leak.

Browse source 
Found by inspection. The STRIP driver does neigh_lookup() but never
releases.  This driver shouldn't being doing gratuitous arp anyway.

Untested, obviously, because of lack of hardware.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Stephen Hemminger 2006-08-29 21:18:45 -07:00 • committed by David S. Miller
parent 57f5f544f5
commit ee1377c3ee
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/net/wireless/strip.c
View file

@ -467,6 +467,7 @@ static int arp_query(unsigned char *haddr, u32 paddr,
struct net_device *dev) struct net_device *dev)
{ {
struct neighbour *neighbor_entry; struct neighbour *neighbor_entry;
int ret = 0;
neighbor_entry = neigh_lookup(&arp_tbl, &paddr, dev); neighbor_entry = neigh_lookup(&arp_tbl, &paddr, dev);
@ -474,10 +475,11 @@ static int arp_query(unsigned char *haddr, u32 paddr,
neighbor_entry->used = jiffies; neighbor_entry->used = jiffies;
if (neighbor_entry->nud_state & NUD_VALID) { if (neighbor_entry->nud_state & NUD_VALID) {
memcpy(haddr, neighbor_entry->ha, dev->addr_len); memcpy(haddr, neighbor_entry->ha, dev->addr_len);
return 1; ret = 1;
} }
neigh_release(neighbor_entry);
} }
return 0; return ret;
} }
static void DumpData(char *msg, struct strip *strip_info, __u8 * ptr, static void DumpData(char *msg, struct strip *strip_info, __u8 * ptr,