evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mac80211: check add_chanctx callback before use in ieee80211_reconfig

Browse source 
During testing our mac80211 driver a fatal error occurred which was
signalled to mac80211. Upon performing the reconfiguration of the
device a WARN_ON was triggered. This warning checked the return value
of drv_add_chanctx(). However, this returns -EOPNOTSUPP when the
driver does not provide the callback. As the callback is optional
better check it is defined before calling drv_add_chanctx().

Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Arend van Spriel 2012-11-19 12:01:05 +01:00 • committed by Johannes Berg
parent f4bda337bb
commit f0dea9c73a
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
net/mac80211/util.c
View file

@ -1417,10 +1417,12 @@ int ieee80211_reconfig(struct ieee80211_local *local)
} }
/* add channel contexts */ /* add channel contexts */
mutex_lock(&local->chanctx_mtx); if (local->use_chanctx) {
list_for_each_entry(ctx, &local->chanctx_list, list) mutex_lock(&local->chanctx_mtx);
WARN_ON(drv_add_chanctx(local, ctx)); list_for_each_entry(ctx, &local->chanctx_list, list)
mutex_unlock(&local->chanctx_mtx); WARN_ON(drv_add_chanctx(local, ctx));
mutex_unlock(&local->chanctx_mtx);
}
list_for_each_entry(sdata, &local->interfaces, list) { list_for_each_entry(sdata, &local->interfaces, list) {
struct ieee80211_chanctx_conf *ctx_conf; struct ieee80211_chanctx_conf *ctx_conf;