From f2af76194a1ced422bc47a13c690e16e92f1cf1e Mon Sep 17 00:00:00 2001 From: Deepak Kushwah Date: Fri, 18 Aug 2017 11:54:56 +0530 Subject: [PATCH] msm: vidc: Avoid setting internal scratch buffers if not required In case of no requirement of internal scratch buffers, driver propagate error to upper layer leading to stream on failure. This commit could avoid setting scratch buffers when there is no requirement. Change-Id: Iedcac8a54f2ae4136b6d885b3955927d4566d9db Signed-off-by: Deepak Kushwah --- drivers/media/platform/msm/vidc/msm_vdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/msm/vidc/msm_vdec.c b/drivers/media/platform/msm/vidc/msm_vdec.c index 0f6389370643..78cced2abd47 100644 --- a/drivers/media/platform/msm/vidc/msm_vdec.c +++ b/drivers/media/platform/msm/vidc/msm_vdec.c @@ -1618,6 +1618,8 @@ static int set_max_internal_buffers_size(struct msm_vidc_inst *inst) get_buff_req_buffer(inst, internal_buffers[i].type); internal_buffers[i].size = internal_buffers[i].req ? internal_buffers[i].req->buffer_size : 0; + if (internal_buffers[i].req == NULL) + continue; rc = allocate_and_set_internal_bufs(inst, internal_buffers[i].req,