evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iscsi_ibft: Fix missing break in switch statement

Browse source 
commit df997abeebadaa4824271009e2d2b526a70a11cb upstream.

Add missing break statement in order to prevent the code from falling
through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: b33a84a384 ("ibft: convert iscsi_ibft module to iscsi boot lib")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Gustavo A. R. Silva 2019-02-11 12:43:23 -06:00 • committed by Greg Kroah-Hartman
parent 91c44982f5
commit f7ff45b8c3
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/firmware/iscsi_ibft.c
View file

@ -513,6 +513,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type)
case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_NIC_ASSOC:
case ISCSI_BOOT_TGT_CHAP_TYPE: case ISCSI_BOOT_TGT_CHAP_TYPE:
rc = S_IRUGO; rc = S_IRUGO;
break;
case ISCSI_BOOT_TGT_NAME: case ISCSI_BOOT_TGT_NAME:
if (tgt->tgt_name_len) if (tgt->tgt_name_len)
rc = S_IRUGO; rc = S_IRUGO;