evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

virtio: fix memory leak in virtqueue_add()

Browse source 
commit 58625edf9e2515ed41dac2a24fa8004030a87b87 upstream.

When using the indirect buffers feature, 'desc' is allocated in
virtqueue_add() but isn't freed before leaving on a ring full error,
causing a memory leak.

For example, it seems rather clear that this can trigger
with virtio net if mergeable buffers are not used.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2016-08-02 14:16:31 +00:00 • committed by Greg Kroah-Hartman
parent 9dddd02de0
commit fa54eea35b
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/virtio/virtio_ring.c
View file

@ -202,6 +202,8 @@ static inline int virtqueue_add(struct virtqueue *_vq,
* host should service the ring ASAP. */ * host should service the ring ASAP. */
if (out_sgs) if (out_sgs)
vq->notify(&vq->vq); vq->notify(&vq->vq);
if (indirect)
kfree(desc);
END_USE(vq); END_USE(vq);
return -ENOSPC; return -ENOSPC;
} }