From fa69b02d4422dc3552f8aa5428741fc8c6d9c84c Mon Sep 17 00:00:00 2001 From: Dhaval Patel Date: Mon, 10 Nov 2014 22:57:40 -0800 Subject: [PATCH] mdss: mdp: release file node before process node when open fail Releasing file node after process node causes the kernel panic because process node is already freed. Correct order to release nodes should be file node followed by process node when PM API fails. CRs-fixed: 753912 Change-Id: I252fc9eabaf0ba81d19b1989b03100849cdeca38 Signed-off-by: Dhaval Patel --- drivers/video/fbdev/msm/mdss_fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/msm/mdss_fb.c b/drivers/video/fbdev/msm/mdss_fb.c index 3e2f5ec279a4..192b9e0197a9 100644 --- a/drivers/video/fbdev/msm/mdss_fb.c +++ b/drivers/video/fbdev/msm/mdss_fb.c @@ -2131,12 +2131,12 @@ blank_error: pm_runtime_put(info->dev); pm_error: + list_del(&file_info->list); + kfree(file_info); if (pinfo && !pinfo->ref_cnt) { list_del(&pinfo->list); kfree(pinfo); } - list_del(&file_info->list); - kfree(file_info); return result; }