evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cs-etm: removing unecessary structure field

Browse source 
Function cs_etm__sample() is called only from cs_etm__run_decoder() where
cs_etm_queue::have_sample is set to 'true'.  As such checking the value of
the variable again in cs_etm__sample() is not needed.

Since the variable isn't used anywhere else, also removing it from the
structure definition.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
This commit is contained in:
Mathieu Poirier 2016-05-20 11:35:25 -06:00
parent 7b4fe2ff5a
commit fb91616a5e
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tools/perf/util/cs-etm.c
View file

@ -83,7 +83,6 @@ struct cs_etm_queue {
u64 time; u64 time;
u64 timestamp; u64 timestamp;
bool stop; bool stop;
bool have_sample;
struct cs_etm_decoder *decoder; struct cs_etm_decoder *decoder;
u64 offset; u64 offset;
bool eot; bool eot;
@ -797,11 +796,6 @@ static int cs_etm__sample(struct cs_etm_queue *etmq)
//struct cs_etm_auxtrace *etm = etmq->etm; //struct cs_etm_auxtrace *etm = etmq->etm;
int err; int err;
if (!etmq->have_sample)
return 0;
etmq->have_sample = false;
err = cs_etm_decoder__get_packet(etmq->decoder,&packet); err = cs_etm_decoder__get_packet(etmq->decoder,&packet);
// if there is no sample, it returns err = -1, no real error // if there is no sample, it returns err = -1, no real error
@ -837,10 +831,8 @@ more:
err = etmq->state->err; err = etmq->state->err;
etmq->offset += processed; etmq->offset += processed;
buffer_used += processed; buffer_used += processed;
if (!err) { if (!err)
etmq->have_sample = true;
cs_etm__sample(etmq); cs_etm__sample(etmq);
}
} while (!etmq->eot && (buffer.len > buffer_used)); } while (!etmq->eot && (buffer.len > buffer_used));
goto more; goto more;